Reviewed 1 of 16 files at r1, 4 of 6 files at r2, all commit messages.
Reviewable status: 5 of 16 files reviewed, 3 unresolved discussions (waiting on @dzmitryhil, @masihyeganeh, and @ysv)

a discussion (no related file):
you should run cargo fmt in the root of the project. some of the style changes that you editor has applied are not default rust style.

x/asset/ft/keeper/test-contracts/asset-extension/src/contract.rs line 282 at r2 (raw file):

    let bank_balance = query_bank_balance(deps, account, &token.denom)?;
    let whitelisted_balance = query_whitelisted_balance(deps, account, &token.denom)?;

we should account for expected to receieve when calculating whitelisting, to showcase how full integration looks likes.

x/asset/ft/keeper/keeper_dex.go line 105 at r2 (raw file):

	expectedToSpend, expectedToReceive sdk.Coin,
) error {
	if err := k.dexCheckExpectedToSpend(ctx, order, expectedToSpend, expectedToReceive); err != nil {

I might be a little confused, but I am not seeing where the whitelisting limits are enforced.

Reviewable status: 5 of 16 files reviewed, 3 unresolved discussions (waiting on @masihyeganeh, @miladz68, and @ysv)

a discussion (no related file):

Done.

x/asset/ft/keeper/keeper_dex.go line 105 at r2 (raw file):

In dexCheckExpectedToReceive

x/asset/ft/keeper/test-contracts/asset-extension/src/contract.rs line 282 at r2 (raw file):

You can query it with the asset FT, Balance query.

Reviewed 8 of 16 files at r1, 6 of 6 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @dzmitryhil, @miladz68, and @ysv)

x/asset/ft/keeper/keeper_dex_test.go line 1067 at r3 (raw file):

	testApp.MintAndSendCoin(t, ctx, acc, sdk.NewCoins(coinWithoutExtension))

	// the extension controls all features, bot to locked, amount

typo?

x/asset/ft/keeper/keeper_dex_test.go line 1119 at r3 (raw file):

	)

	coinWithExtensionProhibitedToReceive := sdk.NewCoin(extensionDenom, sdkmath.NewInt(104))

Please define these magic numbers as a constant just like integration-tests/modules/assetft_extension_test.go

x/asset/ft/keeper/keeper_dex.go line 407 at r3 (raw file):

	}

	if spendDef.IsFeatureEnabled(types.Feature_extension) {

Should we just check if extension is enabled? I believe it's better to change such conditions to check if they implemented that entry point (extension_place_order in this case). I'm not sure if we can check for that or not, but I believe it's the better implementation

Reviewed 7 of 16 files at r1, 2 of 6 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @dzmitryhil and @ysv)

x/asset/ft/keeper/keeper_dex.go line 105 at r2 (raw file):

I am not sure about whitelisting edge cases. let's discuss in a call.

x/asset/ft/keeper/test-contracts/asset-extension/src/contract.rs line 282 at r2 (raw file):

I mean that we should do this in our integration tests as a showcase.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @dzmitryhil and @ysv)

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @masihyeganeh, @miladz68, and @ysv)

x/asset/ft/keeper/keeper_dex.go line 105 at r2 (raw file):

OK

x/asset/ft/keeper/keeper_dex.go line 407 at r3 (raw file):

They must be implemented if they want the FT with an extension to work with the DEX. That was the requirement we agreed on.

x/asset/ft/keeper/keeper_dex_test.go line 1067 at r3 (raw file):

Done

x/asset/ft/keeper/keeper_dex_test.go line 1119 at r3 (raw file):

Agree, updated.

x/asset/ft/keeper/test-contracts/asset-extension/src/contract.rs line 282 at r2 (raw file):

I don't think that this contract is a good example of how to use whitelisting.

Reviewed 4 of 4 files at r5, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68 and @ysv)

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68 and @ysv)

Reviewed 1 of 1 files at r4, 4 of 4 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ysv)

Reviewed 9 of 9 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ysv)

Reviewed 9 of 9 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ysv)